Apply pyupgrade fixes missing from ruff #597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why coverage is failing, but it looks like a remote failure instead of something from our side. |
Yeah, let's keep an eye in the near term |
ricardoV94
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the course of #586 we observed that newer versions of
pyupgrade(the current latest3.15.0vs the outdated3.3.1configured in.pre-commit-config.yaml) caught a few more issues thatruffmissed. I'm not sure why; perhapspyupgradeis more up-to-date thanruff.We can merge these particular fixes, but it's probably worth considering what to do here in general. Like should we still run
pyupgrade, and perhaps alsoflake8in the CI to ensure thatruffisn't missing stuff?Related Issue
Checklist
Type of change